chore(NODE-6939): update typescript to 5.8.3 #4526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
Apr 30, 2025
baileympearson
added
the
Primary Review
baileympearson
requested changes
Apr 30, 2025
durran
force-pushed
the
NODE-6939
branch
3 times, most recently
from
beb0929 to
10bea61
Compare
nbbeeken
suggested changes
May 14, 2025
src/cmap/wire_protocol/on_data.ts
Outdated
| }, | ||
|
|
||
| [Symbol.asyncDispose]: function (): PromiseLike<void> { | ||
| return closeHandler().then(() => undefined); |
There was a problem hiding this comment.
Suggested change
| return closeHandler().then(() => undefined); | |
| async [Symbol.asyncDispose]() { | |
| await closeHandler(); |
a suggestion: nothing wrong with async syntax here I think, just a bit simpler to drop the return value.
There was a problem hiding this comment.
Also probably worth leaving a comment about how this shouldn't be used (I don't think it will but in case).
On older Node versions this is going to be:
{
throw() {/*...*/} // ...
async undefined() {
}
}But typescript isn't going to let you know, ideally a test would fail on node 16 but might as well leave a paper trail.
There was a problem hiding this comment.
Updated for change and comment.
src/cmap/commands.ts
Outdated
| @@ -730,10 +731,19 @@ const COMPRESSION_DETAILS_SIZE = 9; // originalOpcode + uncompressedSize, compre | |||
| * An OP_COMPRESSED request wraps either an OP_QUERY or OP_MSG message. | |||
| */ | |||
| export class OpCompressedRequest { | |||
| private command: WriteProtocolMessageType; | |||
| private options: { zLibCompressionLevel: number; agreedCompressor: CompressorName }; | |||
There was a problem hiding this comment.
Suggested change
| private options: { zLibCompressionLevel: number; agreedCompressor: CompressorName }; | |
| private options: { zlibCompressionLevel: number; agreedCompressor: CompressorName }; |
src/cmap/commands.ts
Outdated
| ) { | ||
| this.command = command; | ||
| this.options = { | ||
| zLibCompressionLevel: options.zlibCompressionLevel, |
There was a problem hiding this comment.
Suggested change
| zLibCompressionLevel: options.zlibCompressionLevel, | |
| zlibCompressionLevel: options.zlibCompressionLevel, |
There was a problem hiding this comment.
should there be some sort of test that catches this?
src/cmap/commands.ts
Outdated
| agreedCompressor: this.options.agreedCompressor | ||
| }, | ||
| messageToBeCompressed | ||
| ); |
There was a problem hiding this comment.
Suggested change
| ); | |
| const compressedMessage = await compress(this.options, messageToBeCompressed); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates typescript to 5.8.3
What is changing?
erasableSyntaxOnlyoption.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6939
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript